Implement long/narrow -> short fallback in babel.units#1225
Implement long/narrow -> short fallback in babel.units#1225akx merged 2 commits intopython-babel:masterfrom
Conversation
|
hi, i noticed 2.18.0 was released recently. is there any chance someone could take a look at this PR? it is really not a complicated fix in my opinion, and this bug causes quite a few strings in our application to go untranslated. (well, currently it's not much of a problem since we are using babel 2.12 which has a much older CLDR, but it would be nice to upgrade.) thanks for all the great work on babel regardless! |
akx
left a comment
akx
left a comment
There was a problem hiding this comment.
LGTM, one tiny performance note.
Sorry reviewing this had fallen through the cracks!
Also implemented fallback from the correct pluralization to "other", which was also missing. Fixes python-babel#1217.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
=======================================
Coverage 92.04% 92.05%
=======================================
Files 27 27
Lines 4715 4719 +4
=======================================
+ Hits 4340 4344 +4
Misses 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Aarni Koskela <akx@iki.fi>
|
Thank you so much! Do you have any plans regarding when the next release will be? I have a project where I've been putting off updating Babel specifically because of this bug, so it would be nice to have a release with the fix included... I was thinking maybe you could do a 2.18.1 when you're done with all the small bugfix PRs? No rush if you have other plans though. |
2 participants
Also implemented fallback from the correct pluralization to "other", which was also missing.
Fixes #1217.